feat(ci): add release build and test stage for PRs #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FalcoSuessgott
changed the title
FalcoSuessgott
force-pushed
the
ci
branch
2 times, most recently
from
bd101a3
to
eeefc9c
Compare
|
I believe, since I opened that PR from my fork I cannot merge it on my own. Perhaps I can merge PRs directly, since I'm now a collaborator :p |
btassone
reviewed
Feb 7, 2024
| hooks: | ||
| # This will check plugin compatibility against latest version of Packer | ||
| post: | ||
| - go install github.com/hashicorp/packer-plugin-sdk/cmd/packer-sdc@latest |
There was a problem hiding this comment.
Why is this section being removed?
.github/workflows/release.yml
Outdated
| @@ -21,14 +22,26 @@ jobs: | |||
| name: Set up Go | |||
| uses: actions/setup-go@v2 | |||
| with: | |||
| go-version: "1.21" | |||
| go-version: "1.16" | |||
There was a problem hiding this comment.
Were there issues with the go version here being set to 1.21 and the version in go.mod being different (it's 1.16 there)?
| GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}" | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| # if no tag test release build |
Updated version to 1.21
Updated to version 1.21
btassone
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hola, @btassone, added some CI tests so we can better check whether dependabot PRs dont break our build pipeline